Remove form-data package from cli-kit entirely#6760
Closed
jordanverasamy wants to merge 1 commit intomainfrom
Closed
Remove form-data package from cli-kit entirely#6760jordanverasamy wants to merge 1 commit intomainfrom
form-data package from cli-kit entirely#6760jordanverasamy wants to merge 1 commit intomainfrom
Conversation
Following the switch to native FormData in f08eeb4, this removes the form-data dependency entirely from cli-kit: - Remove form-data package from cli-kit dependencies - Remove formData() export and FormData import from http.ts - Remove formData test from http.test.ts - Simplify uploadToGCS to not use FormData (was using it incorrectly anyway - sending raw buffer with multipart headers) - Replace Headers type import from form-data with a minimal ResponseHeaders interface that works with both node-fetch and graphql-request Co-Authored-By: Claude Opus 4.5 <[email protected]>
Contributor
|
We detected some changes at Caution DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release. |
jordanverasamy
changed the title
form-data package from cli-kit
jordanverasamy
changed the title
form-data package from cli-kitform-data package from cli-kit entirely
Contributor
Author
|
Aw, turns out we can't remove
We'd need to update |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context: #6756 (comment)
Following up on #6756 which switched bulk uploads to use native
FormData, this removes theform-datapackage entirely fromcli-kit:form-datapackage from cli-kit dependencies (reduces bundle size)formData()export and FormData import fromhttp.tsformDatatest fromhttp.test.tsuploadToGCSto not useFormData(it was being used incorrectly anyway - creating aFormData, appending data, but then sending raw buffer as the body with multipart headers)Headerstype import from form-data with a minimalResponseHeadersinterface that works with bothnode-fetchandgraphql-requestTophatting
[wip]